Removed RemoveMarkupOrThrow in ChatSystem to allow invalid markdown from being set as chat messages - #1336
Open
QuillTheCreature wants to merge 1 commit into
Conversation
… from not sending the message.
github-actions
Bot
added
the
S: Untriaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Sending a message like
[would throw an exception and not allow the message to be sent. This is a PR to allow messages containing invalid markdown.Why / Balance
Let creatures send their messages instead of not doing anything when hitting enter.
Technical details
Before sending a chat message, there's a
FormattedMessage.RemoveMarkupOrThrow(originalMessage);which should strip the message of all formatting.However, since this a
OrThrow()message, this means that the method crashes when a creature sends an "invalid formatted" message, likeHello [.We decided that the player should be able to actually send what they type so we removed that line.
Media
Requirements
Changelog
🆑 Quill